Unoffical empeg BBS

Quick Links: Empeg FAQ | Software | RioCar.Org | Hijack | jEmplode | emphatic
Repairs: Repairs | Addons: Eutronix | Cases

Topic Options
#246549 - 14/01/2005 21:23 Hijack and Mozilla
SE_Sport_Driver
carpal tunnel

Registered: 05/01/2001
Posts: 4903
Loc: Detroit, MI USA
When trying to download mp3s via the Hijack web interface or via Mark's new XML thing, the filenames are truncated after an underscore and are saved with no file extension. IE works like normal.

Is this a Mozilla bug?
_________________________
Brad B.

Top
#246550 - 15/01/2005 01:53 Re: Hijack and Mozilla [Re: SE_Sport_Driver]
mlord
carpal tunnel

Registered: 29/08/2000
Posts: 13630
Loc: Canada
MMm... does the same thing here with Linux Mozilla-1.7.3-5 (Sarge).

It didn't used to screw up. Mozilla bug.

Cheers


Edited by mlord (15/01/2005 01:53)

Top
#246551 - 15/01/2005 12:45 Re: Hijack and Mozilla [Re: mlord]
cushman
veteran

Registered: 21/01/2002
Posts: 1380
Loc: Erie, CO
I'm not so sure it's actually a bug, there is no official RFC for Content-Disposition in HTTP - it is defined in an RFC for MIME messages (RFC 1806). Most browsers generally support it though. Here is a header khttpd returns for a download request:

HTTP/1.1 200 OK
Connection: close
Accept-Ranges: bytes
Content-Length: 301449
Content-Type: audio/mpeg
Content-Disposition: attachment; filename=They Might Be Giants - Doris Cunningham.mp3

I have a suspicion that if all spaces in the filename were converted to underscores (like we do in the web interfaces) it would work fine in Mozilla.
_________________________
Mark Cushman

Top
#246552 - 15/01/2005 21:09 Re: Hijack and Mozilla [Re: cushman]
mlord
carpal tunnel

Registered: 29/08/2000
Posts: 13630
Loc: Canada
I'll give that a try and we'll see.

Cheers

Top
#246553 - 15/01/2005 22:09 Hijack v417 [Re: mlord]
mlord
carpal tunnel

Registered: 29/08/2000
Posts: 13630
Loc: Canada
Yup, Mozilla seems to be too stupid to keep parsing the filename after the first space. But.. it does understand double-quotes for the filename, so I'm changing Hijack to enclose the filename inside double-quotes only for Mozilla. Other agents will continue to receive the raw filename as before. (I seem to recall double quotes being bad in some instances when this was originally implemented))

Fixed in Hijack v417, available shortly.

Cheers

Top
#246554 - 15/01/2005 22:26 Re: Hijack v417 [Re: mlord]
mlord
carpal tunnel

Registered: 29/08/2000
Posts: 13630
Loc: Canada
Heh heh.. Now I know why the default has always been to NOT double-quote the filename here.. IE6 screws up when it is double-quoted!

No problem, though -- Hijack v417 does the correct thing for each of them.

Cheers

Top
#246555 - 15/01/2005 22:27 Re: Hijack v417 [Re: mlord]
SE_Sport_Driver
carpal tunnel

Registered: 05/01/2001
Posts: 4903
Loc: Detroit, MI USA
Way to go!

Does anyone know if Mozilla responds well to bug reports?
_________________________
Brad B.

Top
#246556 - 16/01/2005 00:31 Re: Hijack v417 [Re: SE_Sport_Driver]
cushman
veteran

Registered: 21/01/2002
Posts: 1380
Loc: Erie, CO
Thanks, Mark! I noticed this defect in Mozilla earlier when writing my web interface but didn't have the time to investigate fully.

Quote:
Does anyone know if Mozilla responds well to bug reports?

The reason I said it might not be a bug is because the Content-Disposition header that is used to suggest the filename to the browser is not a standard header in HTTP 1.0 or 1.1 - it is from the MIME standard, and browser writers can even ignore it completely if they like. Certainly Mozilla should have kept parsing to the end of the line, and IE should recognize double quotes, but both of them are supporting a de facto standard in their own way, like so so many other little quirks. Sucks donuts.
_________________________
Mark Cushman

Top
#246557 - 16/01/2005 01:30 Re: Hijack v417 [Re: cushman]
mlord
carpal tunnel

Registered: 29/08/2000
Posts: 13630
Loc: Canada
Ha.. this gets even funnier:

With Konqueror, a left click gives me the correct filename from the content-disposition header, sans underscores.

But a middle-click uses the URL path filename, *with* underscores.

What a riot!

Cheers


Edited by mlord (16/01/2005 01:31)

Top