Hijack SaveAux / RestoreSrc Revisited

Hey all, or should I say, Hey Mark

A few weeks ago I got a new phone (replaced the trusty Treo 650 with a Nokia E61). The new phone has more 'integrated' Bluetooth features which has showed up a few little glitches in the way the Empeg switched sources through SaveAux and RestoreSrc.

To understand the problem, I'll explain a couple of differences between the Nokia and Treo:

• Navigation Audio - I have TomTom running on both of these phones. On the Treo the turn-by-turn instructions always comes out of the speaker on the back of the device (It can not be paired by Bluetooth to both the car kit and the GPS). On the Nokia, the sounds are actually routed through the car kit (it can handle multiple Bluetooth connections at the same time).
  
• Voice Commands - The Treo did not have any voice activation as standard, I think there was some 3rd party software which I didn't get on with. The Nokia actually does real voice recognition and speech synthesis - say the name of anyone in the phone book and it will dial without setting any tags. When you receive a call, it says the persons name through the speakers while ringing. Pretty cool.
  

There are a few other minor differences, but these will help illustrate the problem which is (1) The Empeg does not switch fast enough and (2) When the Empeg is manually set to Aux it seems SaveAux and RestoreSrc is not being ignored. I think it could be switching the Empeg from Aux to Aux which is cutting out the sound for a second.

Reguardless of which 'state' the Empeg is in (even if manually switched to Aux) parts of the TomTom instructions are cut off. "In 300 yards turn right" becomes "yards turn right". It is difficult to use the speech recognition because the 'beep' to signal the start of a voice command is cut off. If someone calls, the phone says their name but I normally only get the last few syllables.

Today I unplugged the Car Kit -> Empeg audio cable and plugged in the little speaker that came with the car kit. All the sounds came through quite nicely and there doesn't seem to be any lag in the Bluetooth connection.

In terms of priority, it is more useful for me to get the 'Sound glitches when manually switched to Aux' problem fixed so the Navigation Audio works. Maybe a line in both SaveAux and RestoreSrc to check "if the previous state and the future state are the same, do nothing" will do it?

Quote:
Maybe a line in both SaveAux and RestoreSrc to check "if the previous state and the future state are the same, do nothing" will do it?

That line is already there:Code:

---

static void
switch_to_src (int from_src, int to_src)
{
        if (from_src != to_src) {
                unsigned int button = 0;
                switch (to_src) {
                        case INPUT_AUX:
                                if (from_src != INPUT_PCM) {
                                        if (!kenwood_disabled) {
                                                button = IR_KW_TAPE_PRESSED;
                                                break;
                                        }
                                        hijack_enq_button_pair(IR_RIO_SOURCE_PRESSED);
                                }
                                // fall thru
                        case INPUT_PCM:
                                button = IR_RIO_SOURCE_PRESSED;
                                break;

                        case INPUT_RADIO_AM:
                                if (from_src != INPUT_RADIO_FM)
                                        hijack_enq_button_pair(IR_RIO_TUNER_PRESSED);
                                // fall thru
                        case INPUT_RADIO_FM:
                                button = IR_RIO_TUNER_PRESSED;
                                break;
                }
                if (button)
                        hijack_enq_button_pair(button);
        }
}

---