Hijack v284: INFO-SEEK fixed

Posted by: mlord

Hijack v284: INFO-SEEK fixed - 25/07/2002 18:35

Okay, I've just put out Hijack v284.

Changes are:

(1) the Knob-press to activate/deactivate the SEEK-TOOL in beta13 now works again.

(2) The S/PDIF patch is now included in empeg-mixer.c

Cheers
Posted by: tfabris

Re: Hijack v284: INFO-SEEK fixed - 25/07/2002 18:43

How does it handle cycling past seektool if you've got the buttonpress set to INFO?
Posted by: mlord

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 06:50

I suppose that once it hits Seek Tool, it will no longer cycle, kinda like a black hole, that. Suggestions?

I suppose we could have an option to remap the seek-tool press to the down button instead of the knob. Not quite as convenience for the rare use of seek-tool, but still very workable for all.

?
Posted by: tfabris

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 07:46

Although it would require a lot of screen scraping and special-case coding to work, how about this:

- If they have reached the seektool screen, and they are obviously cycling through all of the info modes quickly (they've just changed from the last info mode and now they've pressed the button again within 1 sec or so), then treat it like they wanted to change info modes again, it's just another infomode press.

- If they have been on the seektool screen for a while (say, more than 1 sec or so) without pressing the button, then assume they want to enter/exit seektool mode and the button does the empeg default behavior.

- If they enter and exit seektool mode quickly without turning the knob, then assume they want to go back to cycling the info mdes again and do the hijack info press.

This sounds complicated, but I think it would work well.

Either that or we could lobby then to put it back to the original behavior (no volume in seektool mode).
Posted by: mlord

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 08:09

Aw, nevermind. I figured it out.

Hijack allows nested popups, so when the Knob is pressed AND a hijack function has been associated with the knob, then it will popup a choice between seektool and the "other" function (which for most of us is probably PopUp0, but it could be any of the other choices).

The choice doesn't pop-up when exiting seektool.

Hijack v285, shortly.

Cheers
Posted by: tfabris

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 09:09

Much more elegant plan.
Posted by: drakino

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 13:31

This goes along with a long standing wish list item for me, and maybe hijack could do it. Basicially, I dislike the fact that if I cycle through the info modes in the car quickly to get to a visual one, on reboot in the car, it tends to go to the last text mode one touched, Now and Next I believe. I then have to browse the info modes again to get it back to my preferred text mode one, the main information page.

Can hijack somehow work around this? I see it as being similar to the restore visuals hack, but a bit more coding would need to be done to determain if the user was really using now and next, or just going by it.
Posted by: tfabris

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 13:45

It would be nice if Hijack could just echo a bottom-button-longpress to the player at bootup instead of the cycle-through thing. That would take care of it for me.

The fact that the toggle gets switched from track/transient to nownext/transient is the reason I don't use the restore DC visuals option.
Posted by: wfaulk

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 14:22

Wouldn't adding this to your config.ini work?
[ir_translate]

;@DC Initial=bottom.L
Posted by: tfabris

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 14:26

/me tries...
Posted by: tfabris

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 14:30

Didn't seem to do anything.
Posted by: wfaulk

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 14:35

Hmmmm. That's odd. I have an ``;@AC Initial=top.L'' in mine that works fine. (99% of the time I have the player plugged in, it's not for music.)

Edit: And the one I told you to do works for me in AC mode, just to test. Maybe it's a Hijack bug?

Edit again: I forgot. You need to enable notify to get Initial ir_translates to work. Read at the end of this FAQ.
Posted by: tfabris

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 14:39

I also tried:

[ir_translate]
initial.C=Bottom.L

which according to the FAQ should have worked, too. Still nothing.

Note that I'm testing this by doing a force DC/Car mode while it's on the AC adapter, but that should still do OK...
Posted by: wfaulk

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 14:40

Read my second edit above.
Posted by: tfabris

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 14:41

Oh wait. The FAQ also states that before any of this will work, you have to have
[output]
notify=1
Which I don't have. So I'll add that now. That'll probably make it work.
Posted by: wfaulk

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 14:43

No, no, no. I FAQed you first. You can't weasel out of it that easily.
Posted by: tfabris

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 14:45

Hmm, still doesn't work.

This runs:

[ir_translate]
initial.C=Bottom.L

But the Bottom.L isn't L enough, it just opens the main menu. Can I double the length of the L somehow?
Posted by: tfabris

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 14:49

Okay,

[hijack]
button_pacing=40

Seems to have done it.
Posted by: tfabris

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 14:53

Okay, to sum up...


[output]
notify=1

[hijack]
button_pacing=40

[ir_translate]
initial.C=Bottom.L


is what was necessary for me to get it to work.
Posted by: tfabris

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 14:59

Thanks for your help, Bitt, I think this may be a good long term solution. I like the way it works better than the Restore DC/Car feature.

Oh, and Loren, if you see this, you need to document the keypress_flash= parameter in the Hijack FAQ.
Posted by: mlord

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 15:48

Mmm.. the restore DC/Car visuals is supposed to fix this.

I guess maybe it stopped working at some point (?)

I'll look into it someday, unless someone else beats me to it.

-ml
Posted by: wfaulk

Re: Hijack v284: INFO-SEEK fixed - 26/07/2002 17:53

I believe that the problem was that Drakino and Tony didn't like the way Hijack did it:
    I dislike the fact that if I cycle through the info modes in the car quickly to get to a visual one, on reboot in the car, it tends to go to the last text mode one touched, Now and Next I believe. I then have to browse the info modes again to get it back to my preferred text mode one, the main information page.
And it was suggested that it would work better if it just emulated a long bottom press instead of whatever it does now (I don't know what that is, as I don't use that feature).
Posted by: drakino

Re: Hijack v284: INFO-SEEK fixed - 27/07/2002 02:54

I wasn't actually commenting on any hijack feature, and prefer to keep my player in a text mode most of the time in the car, thus the normal "legal" feature of going back to a text mode on boot is fine with me.

What I was asking for is a workaround for when the player restores "Now and Next" even though I only spent a second on the screen before hitting a button to switch it to the visual mode. This is probably more approiate as a player feature, but I figured I'd drop the idea here for hijack since the idea was burried somewhere in the Wish List forum.
Posted by: tman

Re: Hijack v284: INFO-SEEK fixed - 27/07/2002 09:01

There's a mistake in the S/PDIF bits in v285. I've attached a new patch for v285 that should fix it. Must remember to use unified diff next time

- Trevor
Posted by: mlord

Re: Hijack v284: INFO-SEEK fixed - 28/07/2002 07:26

Ah, yes. Much better with the unified diff format, thanks.

Patch applied for v286.
Posted by: mlord

Re: Hijack v284: INFO-SEEK fixed - 28/07/2002 07:41

Ahh, thanks for the clarification Drakino. I was wondering what you meant originally.

So, are you perhaps looking for a "car_info=track" type of setting for config.ini, or what?

cheers
Posted by: mlord

Re: Hijack v284: INFO-SEEK fixed - 28/07/2002 07:47

Which "toggle" is that, Tony?

Does "long-bottom-button" normally toggle back and forth between the visual and text INFO? Cool.

-ml
Posted by: tfabris

Re: Hijack v284: INFO-SEEK fixed - 28/07/2002 10:36

Which "toggle" is that, Tony? Does "long-bottom-button" normally toggle back and forth between the visual and text INFO? Cool.

The long-bottom-button toggles between your last-selected-textmode, and your last-selected-visualmode, whatever they may have been.

For instance, if, from the menu, I select: "Info:Off" followed by "Info:Now and Next", then all subsequent long-bottom-buttons will toggle between those two modes.

My preference is to toggle between "Info:Transient" and "Info:Track". However, if one cycles through the info modes to land upon "Transient", then just by virtue of the ordering of the screens, the last selected textmode was "Now and Next" and that becomes the toggle.

Since the "Restore DC/Car Visuals" feature does precisely that (cycles through all the infomodes), then when it's done with its job, the toggle is left back at "Now and Next" instead of "Track".

If the "Restore DC/Car Visuals" used a long-bottom-button instead of a bunch of info presses to do its job, then it would always toggle back to whatever they left it on.

Of course, the IR_Translate trick that Bitt showed me accomplishes the same task, so it's not critical for me any more (except that the IR_Translate trick seems to still work only intermittently, I'm trying different values for button pacing to see if I can make it work better).
Posted by: tfabris

Re: Hijack v284: INFO-SEEK fixed - 28/07/2002 10:42

If the "Restore DC/Car Visuals" used a long-bottom-button instead of a bunch of info presses to do its job, then it would always toggle back to whatever they left it on.

And then I go over to read the next thread and see:

-- The Restore DC/Car Visuals now just issues a down.L keypress on player startup, eliminating all of the complex logic from the past. This requires "notify=1" in config.ini.

My only fear is that the above change will only work intermittently if it uses the same mechanism as the IR_Translate trick. Of course, the cycle-through-the-info-modes trick only ever worked intermittently for me anyway.
Posted by: wfaulk

Re: Hijack v284: INFO-SEEK fixed - 28/07/2002 19:14

    except that the IR_Translate trick seems to still work only intermittently
That's odd. My top.L translation works for me 100% of the time, and I've never touched the button pacing.
Posted by: drakino

Re: Hijack v284: INFO-SEEK fixed - 30/07/2002 10:48

So, are you perhaps looking for a "car_info=track" type of setting for config.ini, or what?

That would work in this situation, yes. Idealially the software (hijack or player) would be smart enough to detect the difference between when I use an info mode, and when I am just skipping by it to move to the next one. That would probably be more hassle then it's worth in Hijack, so the solution of a hard coded setting for the desired info mode on DC would work.