hijack SETGEOM bug

Posted by: kirkis

hijack SETGEOM bug - 06/09/2002 03:08

Please excuse me if I've made a mistake, but I think there is a bug in hijack.

I don't see how an app can request to use the full screen when lastcol must be both < 128 and a multiple of 2, in a call to SETGEOM. Passing 127 for this parameter causes an error.

What do you think?

Richard
--
Posted by: mlord

Re: hijack SETGEOM bug - 06/09/2002 09:30

Don't use SETGEOM if you want the full screen -- it is intended only for use with a smaller window overlaid on the screen.

-ml
Posted by: kirkis

Re: hijack SETGEOM bug - 06/09/2002 15:06

Okay then thanks for answering Mark. Still this seems a bit inconsistent with the documentation (in hijack.h) that seems to suggest that you can do such a thing.

Also, what if an app wanted to switch between an overlay and fullscreen mode?

Cheers,

Richard
--
Posted by: mlord

Re: hijack SETGEOM bug - 06/09/2002 18:53

>what if an app wanted to switch between an overlay and fullscreen mode?

If it invokes SETGEOM with the exact screen dimensions, then Hijack reverts to fullscreen: first_row=0, last_row=31, first_col=0, last_col=131

-ml
Posted by: kirkis

Re: hijack SETGEOM bug - 11/09/2002 19:54

Yes, but that's what I'm trying to say - as far as I can tell you can't specify the exact screen dimensions - specifically last_col can't be set to the last screen column.

Of course, I could be mistaken.

Not that this is a major problem or anything. Hijack rocks! Without it empacman would not exist.

Cheers,

Richard
--
Posted by: mlord

Re: hijack SETGEOM bug - 12/09/2002 05:51

Ahh.. Got it -- the error-checking in the code got a little carried away. Fixed for v293.