I haven't heard any reports of recovered data with the new secure erase being used in iPhone 2.0+

The dialog claims it takes about an hour to erase - that sounds pretty rigorous to me. Just don't deactivate the phone before erasing - you won't be able to access the feature.

http://discussions.apple.com/thread.jspa?threadID=1604038&tstart=881