Unoffical empeg BBS

Quick Links: Empeg FAQ | RioCar.Org | Hijack | BigDisk Builder | jEmplode | emphatic
Repairs: Repairs

Page 3 of 3 < 1 2 3
Topic Options
#202939 - 09/02/2004 22:20 Re: Hijack v366 [Re: mlord]
Daria
carpal tunnel

Registered: 24/01/2002
Posts: 3937
Loc: Providence, RI
Well, um, yeah, the amended version of the patch looks ok. I guess I'll dig the GPS out again and try.

Top
#202940 - 09/02/2004 22:42 Re: Hijack v366 [Re: Daria]
Daria
carpal tunnel

Registered: 24/01/2002
Posts: 3937
Loc: Providence, RI
Looks like read() on the serial port now returns EIO.

Top
#202941 - 09/02/2004 23:25 Re: Hijack v366 [Re: mlord]
Daria
carpal tunnel

Registered: 24/01/2002
Posts: 3937
Loc: Providence, RI
Hm. So, I commented out the pgrp line again and reverted the change to tty_check_change back to what it was in 363, and I still lose. I very definitely won in 363 with just the pgrp change. I guess I should diff 363 to 367.

Top
#202942 - 10/02/2004 00:23 Re: Hijack v366 [Re: Daria]
Daria
carpal tunnel

Registered: 24/01/2002
Posts: 3937
Loc: Providence, RI
Hm.
in read_chan I see
else if (current->pgrp != tty->pgrp) {
if (is_ignored(SIGTTIN) ||
is_orphaned_pgrp(current->pgrp))
return -EIO;
kill_pg(current->pgrp, SIGTTIN, 1);
return -ERESTARTSYS;
}
I wonder if SIGTTIN is ignored. This check of course bypasses the thing you patched.

Top
#202943 - 10/02/2004 00:35 Hijack fixed for GPSapp again [Re: Daria]
Daria
carpal tunnel

Registered: 24/01/2002
Posts: 3937
Loc: Providence, RI
Make read_chan be symmetric with tty_check_change.

--- drivers/char/n_tty.c 11 Oct 2003 22:14:12 -0000 1.2
+++ drivers/char/n_tty.c 10 Feb 2004 06:33:05 -0000
@@ -956,7 +956,8 @@
current->tty == tty) {
if (tty->pgrp <= 0)
printk("read_chan: tty->pgrp <= 0!\n");
- else if (current->pgrp != tty->pgrp) {
+ else if ((current->pgrp != tty->pgrp) &&
+ (tty->device != MKDEV(TTY_MAJOR,65))) {
if (is_ignored(SIGTTIN) ||
is_orphaned_pgrp(current->pgrp))
return -EIO;

Top
#202944 - 10/02/2004 08:42 Re: Hijack fixed for GPSapp again [Re: Daria]
mlord
carpal tunnel

Registered: 29/08/2000
Posts: 14491
Loc: Canada
Okay. v368 will have this change in a few minutes.

Top
#202945 - 10/02/2004 11:25 Re: Hijack fixed for GPSapp again [Re: mlord]
crazymelki
enthusiast

Registered: 16/02/2001
Posts: 373
Loc: Switzerland
Thanks Mark,

The Charcoalgray99 Empeg web (Now Playing Info) was also broken after my upgrade to Alpha6 and HiJack V363. But it works now again...

bye
_________________________
crazymelki.com

Top
#202946 - 10/02/2004 12:12 Re: Hijack fixed for GPSapp again [Re: mlord]
tfabris
carpal tunnel

Registered: 20/12/1999
Posts: 31594
Loc: Seattle, WA
Okay. v368 will have this change in a few minutes.
Tested! It works! Mark and Derrick, thanks very much for your time and your attention to detail. Too cool.
_________________________
Tony Fabris

Top
#202947 - 10/02/2004 12:25 Re: Hijack fixed for GPSapp again [Re: crazymelki]
mlord
carpal tunnel

Registered: 29/08/2000
Posts: 14491
Loc: Canada
The Charcoalgray99 Empeg web (Now Playing Info) was also broken after my upgrade to Alpha6
Yes, I posted a note about this in the Merry Christmas thread (which is really the v3alpha thread).

Basically, v3alpha6 has the two serial streams (console messages vs. output->notify messages) reversed from normal somewhere. I haven't the foggiest how/why, but I did recently just update Hijack to reverse it's processing of them internally to compensate, whenever running a v3alpha release. Very peculiar.

Cheers

Top
#202948 - 13/02/2004 22:01 Re: Hijack v366 [Re: Daria]
genixia
Carpal Tunnel

Registered: 08/02/2002
Posts: 3411
I didn't really follow all the technicalities of this thread, but should telnetd be broken as of Hijack v372 ?
The connection is killed immediately.
_________________________
Mk2a 60GB Blue. Serial 030102962 sig.mp3: File Format not Valid.

Top
#202949 - 13/02/2004 22:19 Re: Hijack v366 [Re: genixia]
Daria
carpal tunnel

Registered: 24/01/2002
Posts: 3937
Loc: Providence, RI
Probably not. I'm telnetted in now, seems to not be dying

Top
#202950 - 13/02/2004 23:10 Re: Hijack v366 [Re: Daria]
genixia
Carpal Tunnel

Registered: 08/02/2002
Posts: 3411
Crap. That means I screwed something up when upgrading to v3a7. I wonder what though - the connection is made so the server is running...
_________________________
Mk2a 60GB Blue. Serial 030102962 sig.mp3: File Format not Valid.

Top
#202951 - 13/02/2004 23:42 Re: Hijack v366 [Re: genixia]
Daria
carpal tunnel

Registered: 24/01/2002
Posts: 3937
Loc: Providence, RI
You zapped all the ttys. Run the devs script again.

Top
#202952 - 14/02/2004 00:19 Re: Hijack v366 [Re: Daria]
genixia
Carpal Tunnel

Registered: 08/02/2002
Posts: 3411
Doh! Thanks. I'd completely forgotten about that little detail.
_________________________
Mk2a 60GB Blue. Serial 030102962 sig.mp3: File Format not Valid.

Top
Page 3 of 3 < 1 2 3